Generated by 🚫 dangerJS against 84579fa

Looks good at first glance, even though it feels like it's a lot of new API for a very specific use case. Since the goal is to add attachments to envelopes, I wonder if it would make sense to open up some of the existing but internal envelope APIs to make the same achievable in a more generic way. What do you think?

Since the goal is to add attachments to envelopes, I wonder if it would make sense to open up some of the existing but internal envelope APIs to make the same achievable in a more generic way.

To elaborate a bit, I'd propose wrapping/exposing the missing parts from sentry_envelope.h so that the code becomes:

sentry_value_t feedback = sentry_value_new_feedback(...);

sentry_envelope_t *envelope = sentry_envelope_new();
sentry_envelope_add_feedback(envelope, feedback);
sentry_envelope_attach_file(envelope, "screenshot.png");

sentry_capture_envelope(envelope);

Exposing internal envelope APIs sounds like a reasonable alternative to me.

However, if there are any concerns about doing so, the newly introduced hint type (perhaps with a more generic name like sentry_hint_t instead of sentry_feedback_hint_t) could serve as a public interface for attaching extra data to captured events as well.

Also, the before_send callback already accepts a hint parameter (currently defaulted to NULL) which might be repurposed for this as well - for example, in Android SDK the beforeSend handler provides a hint parameter that can be used to attach files to specific events. This contrasts with the current approach in Unreal SDK where attachments (like game screenshot) are added to the global scope during the on_crash hook processing so that crashpad can pick them up during uploading the event.

UPD: sentry_feedback_hint_t was renamed to sentry_hint_t to support a wider range of use cases (e.g. for events capturing).